5e0b6e7...
by
OpenDev Sysadmins <email address hidden>
OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:
Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.
This is a mechanically generated change to replace openstack.org
git:// URLs with https:// equivalents.
This is in aid of a planned future move of the git hosting
infrastructure to a self-hosted instance of gitea (https://gitea.io),
which does not support the git wire protocol at this stage.
This update should result in no functional change.
In this charm we run a cron job to check rabbitmq status and it is
possible that the commands run could fail or hang if e.g. rabbit
is not healthy. Currently the cron will never timeout and could
hang forever so we add a new timeout config option 'cron-timeout'
which, when set, will result in the a SIGINT being sent to the
application and if that fails to exit within 10s a SIGKILL is sent.
We also fix logging so that all output goes to syslog local0.notice.
Change-Id: I0bb8780c5cc64a24384648f00c8068d5d666d28c
Closes-Bug: 1716854
(cherry picked from commit ff4da882a21233c3c67d7cf74f3f028c78328e14)
This change solves two problmes. First, one off problems waiting
for the cluster to complete. Second, running update_clients too
often. Update clients will get executed only once as soon as
leader_node_is_ready() or client_node_is_ready() returns True.
Subsequent client requests will be handled by normal
amqp-relation-changed hooks.
Co-Authored-By: Liam Young <email address hidden>
Partial-Bug: #1717579
Change-Id: I02c648cccc72d816beeec5546b6c7914d57c607a
(cherry picked from commit 9f9646bc356f269f14b2112f96f2112e8b647f23)
Some Rabbitmq clients gate enabling ssl on the presence of the
ssl_port option in the amqp relation. However, when ssl is disabled
the rabbitmq-server charm does not explicitly unset ssl_port so it
persists down the relation. This change unsets the ssl_port
option along with the other ssl options when they are not needed.
There seemed to be no unit test coverage for ssl_utils so I've
added some as part of this change.
Change-Id: If957899427ec979d09045baca010375ba7273579
Closes-Bug: #1717982
(cherry picked from commit 407cfa80975a170bf2b34b9ea60d0d9e49109971)
The commit [0] added a explicit call to update_clients
which is executed on every hook run (including update-status),
the update_clients function iterates over all the units
related through the amqp relation and makes a call
to the amqp_changed function.
As the update_status hook interval is set to run every 5 minutes,
isn't convenient to do a call to amqp_changed for every related unit
particularly in large scale deployments, as this might cause
an unwanted workload overhead on the cloud at every tick
of the update-status hook.
Further work needs to be done to improve the overall
handling performed via the update_clients function but
this commit alleviates the problem of leaving the update-status
hook stuck for ~1 hour every time.
