Code review comment for lp:~openerp/openobject-server/web-dashboard

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Also in the first section of the bin/addons/base/ir/ir_ui_menu.py code, why `res[menu.id].update({'web_icon_hover_datas': icon_hover,})`?

* Why call update rather than __setitem__
* Why provide a dict rather than use kwargs?

All in all, why not just use `res[menu.id]['web_icon_hover_datas'] = icon_hover`

review: Needs Fixing

« Back to merge proposal