Code review comment for lp:~openerp/openobject-client/property_attribute

Revision history for this message
Christophe CHAUVET (christophe-chauvet) wrote :

Hi

That a great feature, for ours cutomers we often inherit create or write to put uppercase or lowercase on their profile, if we can just add property="upper" it really great.

But to convert in upper or lower, please use lower or upper python function on a unicode string [1], and don't substitute ascii code.

for numeric, it's more complexe and i don't think it a good idea to include it

You can add "title" [2] property

Regards,

[1] : http://stackoverflow.com/questions/727507/how-can-i-do-unicode-uppercase
[2] : http://docs.python.org/library/stdtypes.html?highlight=title#str.title

review: Needs Fixing

« Back to merge proposal