Code review comment for lp:~openerp/openobject-client-web/trunk-bug-filters-niv

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

* Don't revert the parsing to simplejson, the data received is not necessarily in JS, because they can come from e.g. switch_SearchView which throws raw Python datastructures in there so filters are breaking when e.g. switching to Form view then back to List
* The else branch within the ilike/not ilike case is not correct, '%' is added by the server and adding it in JS breaks the custom filters when switching back from other views (or saving)
* Is it really necessary to revert the whole revision instead of just the fields handling? Do you know why they were originally removed?

review: Needs Fixing

« Back to merge proposal