Merge lp:~openerp-dev/openobject-server/trunk-uninstall-tpa into lp:openobject-server

[Turkesh Patel (openERP)]

Improved code to remove module uninstallation issues.
=====================================================================================
--> remove ir.action.todo also related to the actions otherwise it will fire that TODO and will try to find that action. And whithout action TODO is useless.
--> Improved query to find constraints to be deleted.

[lp:~openerp-dev/openobject-server/trunk-uninstall-tpa]

4676. By Turkesh Patel (openERP) on 2012-12-13

[IMP] improved code and comment.

4677. By Turkesh Patel (openERP) on 2012-12-13

[MRG] merge with lp:openobject-server

4678. By Turkesh Patel (openERP) on 2013-02-14

[MRG] merge with lp:openobject-server

4679. By Turkesh Patel (openERP) on 2013-02-21

[IMP] remove now not-required changes.

4680. By Turkesh Patel (openERP) on 2013-02-21

[MRG] merge with lp:openobject-server

4681. By Turkesh Patel (openERP) on 2013-02-26

[MRG] merge with lp:openobject-server

4682. By Turkesh Patel (openERP) on 2013-03-01

[MRG] merge with lp:openobject-server

4683. By Turkesh Patel (openERP) on 2013-03-18

[MRG] merge with lp:openobject-server

4684. By Turkesh Patel (openERP) on 2013-03-25

[MRG] merge with lp:openobject-server

4685. By Turkesh Patel (openERP) on 2013-04-17

[MRG] merge with lp:openobject-server

4686. By Turkesh Patel (openERP) on 2013-05-22

[MRG] merge with lp:openobject-server

4687. By Turkesh Patel (openERP) on 2013-06-05

[MRG] merge with lp:openobject-server

4688. By Turkesh Patel (openERP) on 2013-06-20

[MRG] merge with lp:openobject-server

4689. By Turkesh Patel (openERP) on 2013-09-17

[MRG] merge with lp:openobject-addons

4690. By Turkesh Patel (openERP) on 2013-09-26

[MRG] merge with lp:openobject-server

4691. By Turkesh Patel (openERP) on 2013-09-26

[MRG] use try-except to avoid error after uninstallation of module in which we have set menu to load in context.

4692. By Turkesh Patel (openERP) on 2013-11-11

[MRG] merge with lp:openobject-server

4693. By Turkesh Patel (openERP) on 2013-11-20

[MRG] merge with lp:openobject-server

4694. By Turkesh Patel (openERP) on 2013-11-28

[IMP] improved code

4695. By Turkesh Patel (openERP) on 2013-11-28

[MRG] merge with lp:openobject-server

4696. By Turkesh Patel (openERP) on 2014-03-06

[MRG] merge with lp:openobject-server

4697. By Turkesh Patel (openERP) on 2014-04-25

[MRG] merge with lp:openobject-addons

Unmerged revisions

4697. By Turkesh Patel (openERP) on 2014-04-25

[MRG] merge with lp:openobject-addons

4696. By Turkesh Patel (openERP) on 2014-03-06

[MRG] merge with lp:openobject-server

4695. By Turkesh Patel (openERP) on 2013-11-28

[MRG] merge with lp:openobject-server

4694. By Turkesh Patel (openERP) on 2013-11-28

[IMP] improved code

4693. By Turkesh Patel (openERP) on 2013-11-20

[MRG] merge with lp:openobject-server

4692. By Turkesh Patel (openERP) on 2013-11-11

[MRG] merge with lp:openobject-server

4691. By Turkesh Patel (openERP) on 2013-09-26

[MRG] use try-except to avoid error after uninstallation of module in which we have set menu to load in context.

4690. By Turkesh Patel (openERP) on 2013-09-26

[MRG] merge with lp:openobject-server

4689. By Turkesh Patel (openERP) on 2013-09-17

[MRG] merge with lp:openobject-addons

4688. By Turkesh Patel (openERP) on 2013-06-20

[MRG] merge with lp:openobject-server

=== modified file 'openerp/addons/base/ir/ir_actions.py'
--- openerp/addons/base/ir/ir_actions.py	2014-04-07 17:46:28 +0000
+++ openerp/addons/base/ir/ir_actions.py	2014-04-25 10:58:25 +0000
@@ -57,6 +57,13 @@
         'usage': lambda *a: False,
     }
 
+    def unlink(self, cr, uid, ids, context=None):
+        """unlink ir.action.todo which are related to actions which will be deleted.
+           NOTE: ondelete cascade will not work on ir.actions.actions so we will need to do it manually."""
+        todo_obj = self.pool.get('ir.actions.todo')
+        todo_ids = todo_obj.search(cr, uid, [('action_id', 'in', ids)], context=context)
+        todo_obj.unlink(cr, uid, todo_ids, context=context)
+        return super(actions, self).unlink(cr, uid, ids, context=context)
 
 class ir_actions_report_xml(osv.osv):
 
 
=== modified file 'openerp/addons/base/ir/ir_ui_menu.py'
--- openerp/addons/base/ir/ir_ui_menu.py	2013-10-06 13:24:24 +0000
+++ openerp/addons/base/ir/ir_ui_menu.py	2014-04-25 10:58:25 +0000
@@ -312,9 +312,12 @@
                     menu_ref = [menu_ref]
                 model_data_obj = self.pool.get('ir.model.data')
                 for menu_data in menu_ref:
-                    model, id = model_data_obj.get_object_reference(cr, uid, menu_data.split('.')[0], menu_data.split('.')[1])
-                    if (model == 'ir.ui.menu'):
-                        menu_ids.add(id)
+                    try:
+                        model, id = model_data_obj.get_object_reference(cr, uid, menu_data.split('.')[0], menu_data.split('.')[1])
+                        if (model == 'ir.ui.menu'):
+                            menu_ids.add(id)
+                    except Exception:
+                        pass
         menu_ids = list(menu_ids)
 
         for menu in self.browse(cr, uid, menu_ids, context=context):