Code review comment for lp:~openerp-dev/openobject-server/trunk-test_cursor-rco

Revision history for this message
Christophe Simonis (OpenERP) (kangol) wrote :

in file openerp/addons/base/tests/test_db_cursor.py, you can keep the context manager.
in file openerp/sql_db.py: in TestCursor() no need to ovewrite method execute to just call super()

more generally, I'm pretty sure there is still addons that call `registry.db.cursor()`.
To forbid that, can you rename the `db` variable to `__db` (it's private after all)

« Back to merge proposal