Merge lp:~openerp-dev/openobject-server/trunk-bug-863221-nch into lp:openobject-server
Proposed by
Naresh(OpenERP)
Status: | Merged |
---|---|
Approved by: | Olivier Dony (Odoo) |
Approved revision: | 3799 |
Merged at revision: | 3881 |
Proposed branch: | lp:~openerp-dev/openobject-server/trunk-bug-863221-nch |
Merge into: | lp:openobject-server |
Diff against target: |
19 lines (+8/-1) 1 file modified
openerp/addons/base/ir/ir_sequence.py (+8/-1) |
To merge this branch: | bzr merge lp:~openerp-dev/openobject-server/trunk-bug-863221-nch |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Dony (Odoo) | Approve | ||
Vo Minh Thu | Pending | ||
Review via email: mp+82124@code.launchpad.net |
To post a comment you must log in.
Looks good, but when merging I suggest we also:
- change the search() in _next_by_* to use order="company_id" to give higher priority to company-specific
sequences when no sequence is found for preferred company (this will work because NULLs are sorted
last in PostgreSQL)
- add something in the docstrings to mention that force_company can be passed