Code review comment for lp:~openerp-dev/openobject-server/trunk-bug-726592-ysa

Revision history for this message
Yogesh (SerpentCS) (yogesh-serpentcs) wrote :

Hello Sir,

I checked this issue. I found problem in if id_val is not default_val: condition. if property field type is m2o then this condition always true and new record create in ir.property object. if field type is m2o then self._get_default() return the browse record so id_val is simple int id and default_val is browse record so never match the default record. so in this situation check the default_val have _id attribute if yes then check and fetch id of that field like defult_val._id and check this with id_val if not match then create record of property object. if field type is not m2o then check simple condition like :- id_val != default_val.

If I missing some thing then correct me.

Thanks,

review: Needs Resubmitting

« Back to merge proposal