Code review comment for lp:~openerp-dev/openobject-server/trunk-bug-712254-ysa

Revision history for this message
Vo Minh Thu (thu) wrote :

Actually, the call to _company_default_get shouldn't be there (it is unrelated to the property field). We also want to make the read/write function be much simpler, with the main work being done in ir.properties.

qdp will work on it (next week I think) as part of some larger rework, so I will reject this merge proposal.

Part of the reason it needs a rework is that at creation time, the company is chosen (wrongly) by _company_default_get. Later when we want to read the property, we have no idea of the company that was chosen and cannot decide which property is the right one.

« Back to merge proposal