Code review comment for lp:~openerp-dev/openobject-server/trunk-bug-712254-ysa

Revision history for this message
Vo Minh Thu (thu) wrote :

- You are computing the company_id with

  company_id = obj.pool.get('res.users').browse(cr, uid, uid, context).company_id.id

but later in _fnct_write, it is computed with

  cid = company._company_default_get(cr, uid, obj._name, def_id, context=context)

Did you choose the former for a specific reason?

- You have made twice the same modification. Please refactor the code when you see duplicated code.

« Back to merge proposal