Merge lp:~openerp-dev/openobject-server/trunk-bug-1032928-pja into lp:openobject-server

Proposed by Jalpesh Patel(OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-server/trunk-bug-1032928-pja
Merge into: lp:openobject-server
Diff against target: 27 lines (+3/-2)
2 files modified
openerp/addons/base/res/res_currency.py (+3/-0)
openerp/addons/base/test/base_test.yml (+0/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/trunk-bug-1032928-pja
Reviewer Review Type Date Requested Status
Atul Patel(OpenERP) Pending
Review via email: mp+132309@code.launchpad.net

Description of the change

Hello sir,

     I have improved code of res_currency.py file to fix problem of set base currency rate 0,when going to pay invoice it's given float division error.

Thanks!
pja

To post a comment you must log in.
4522. By Jalpesh Patel(OpenERP)

[IMP]improve code try_roundtrip method

Unmerged revisions

4522. By Jalpesh Patel(OpenERP)

[IMP]improve code try_roundtrip method

4521. By Jalpesh Patel(OpenERP)

[FIX] fix problem of set base currency rate 0,float division error generated when going to pay invoice

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openerp/addons/base/res/res_currency.py'
--- openerp/addons/base/res/res_currency.py 2012-08-30 08:49:54 +0000
+++ openerp/addons/base/res/res_currency.py 2012-11-01 06:28:18 +0000
@@ -243,6 +243,9 @@
243 _defaults = {243 _defaults = {
244 'name': lambda *a: time.strftime('%Y-%m-%d'),244 'name': lambda *a: time.strftime('%Y-%m-%d'),
245 }245 }
246 _sql_constraints = [
247 ('check_rate', 'CHECK (rate>0.0)', 'Currency rate must be greater than 0.0 !'),
248 ]
246 _order = "name desc"249 _order = "name desc"
247250
248res_currency_rate()251res_currency_rate()
249252
=== modified file 'openerp/addons/base/test/base_test.yml'
--- openerp/addons/base/test/base_test.yml 2012-08-22 11:06:04 +0000
+++ openerp/addons/base/test/base_test.yml 2012-11-01 06:28:18 +0000
@@ -281,9 +281,7 @@
281 assert rate == expected, 'Roundtrip error: got %s back from db, expected %s' % (rate, expected)281 assert rate == expected, 'Roundtrip error: got %s back from db, expected %s' % (rate, expected)
282 # res.currency.rate uses 6 digits of precision by default282 # res.currency.rate uses 6 digits of precision by default
283 try_roundtrip(2.6748955, 2.674896)283 try_roundtrip(2.6748955, 2.674896)
284 try_roundtrip(-2.6748955, -2.674896)
285 try_roundtrip(10000.999999, 10000.999999)284 try_roundtrip(10000.999999, 10000.999999)
286 try_roundtrip(-10000.999999, -10000.999999)
287285
288-286-
289 "Float precision tests: verify that invalid parameters are forbidden"287 "Float precision tests: verify that invalid parameters are forbidden"