It looks better now, but:
- you don't need backslashes within a literal dict declaration
- the one-liner with the eval is difficult to read now, could you split it in multiple lines (but keep the lazy creation of the eval dict, i.e. only eval the domain if menu.action.domain is set
- in case an exception occurs, it could be useful to log a warning, something like:
_logger.warning("Action domain '%s' could not be processed to filter need-action data, ignoring it.", exc_info=True)
Hi,
Thanks for updating the merge proposal.
It looks better now, but: warning( "Action domain '%s' could not be processed to filter need-action data, ignoring it.", exc_info=True)
- you don't need backslashes within a literal dict declaration
- the one-liner with the eval is difficult to read now, could you split it in multiple lines (but keep the lazy creation of the eval dict, i.e. only eval the domain if menu.action.domain is set
- in case an exception occurs, it could be useful to log a warning, something like:
_logger.
Thanks,