Odoo Server (MOVED TO GITHUB)

Code review comment for lp:~openerp-dev/openobject-server/7.0-opw-591889-dhs

  1. 7.0-opw-591889-dhs
  2. Merge into 7.0
Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Guys,

I believe, the attached proposal does not solve the problem, it just gets the traceback out of your way.

Rather than catching the bug and skipping it from the receiving end, we should better shut the root of the error.

It's obvious that the message will not be relevant to any model whatsoever (if its composed just as an email), so stands no logic to call the unnecessary write() and thus 5 other methods.

Relevant proposal appears on the bug!

Hope this helps.

Corrections are invited.

Thanks.

« Back to merge proposal