Code review comment for lp:~openerp-dev/openobject-server/7.0-fix-contact-company-handling

Hello Again.

In the field,

+ 'commercial_id': fields.function(_commercial_id_compute, type='many2one', relation='res.partner', string='Commercial Entity')

shouldn't It be store = True?,

Several reports with SQL will depend of it, and we have a lot, all our fiscal reports are so complicated in Venezuela and Mexico, and we use a lot of SQL to compute them, IOH, it allow audit better the data in terms of go directly SQL access, and control external tools.

See here a good example:

http://bazaar.launchpad.net/~openerp-venezuela/openerp-venezuela-localization/trunk/view/head:/l10n_ve_fiscal_reports_V2/l10n_ve_fiscal_reports.py#L65

I think this important field not recorded is dangerous and a bad design, (this is one of thing a critizice a lot from other tools have business logic without trace in data base, remember this is a "Legal" element.

Thanks.