Merge lp:~openerp-dev/openobject-server/6.1-fix_tools.email_send-chs into lp:openobject-server/6.1

Proposed by Christophe Simonis (OpenERP)
Status: Merged
Merged at revision: 4090
Proposed branch: lp:~openerp-dev/openobject-server/6.1-fix_tools.email_send-chs
Merge into: lp:openobject-server/6.1
Diff against target: 42 lines (+3/-4)
2 files modified
openerp/addons/base/ir/ir_mail_server.py (+1/-2)
openerp/tools/misc.py (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/6.1-fix_tools.email_send-chs
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Approve
Review via email: mp+96191@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Woops, thanks for spotting!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openerp/addons/base/ir/ir_mail_server.py'
--- openerp/addons/base/ir/ir_mail_server.py 2012-01-24 11:47:30 +0000
+++ openerp/addons/base/ir/ir_mail_server.py 2012-03-06 17:36:39 +0000
@@ -2,7 +2,7 @@
2##############################################################################2##############################################################################
3#3#
4# OpenERP, Open Source Management Solution4# OpenERP, Open Source Management Solution
5# Copyright (C) 2011 OpenERP S.A (<http://www.openerp.com>)5# Copyright (C) 2011-2012 OpenERP S.A (<http://www.openerp.com>)
6#6#
7# This program is free software: you can redistribute it and/or modify7# This program is free software: you can redistribute it and/or modify
8# it under the terms of the GNU Affero General Public License as8# it under the terms of the GNU Affero General Public License as
@@ -364,7 +364,6 @@
364 :param smtp_user: optional SMTP user, if mail_server_id is not passed364 :param smtp_user: optional SMTP user, if mail_server_id is not passed
365 :param smtp_password: optional SMTP password to use, if mail_server_id is not passed365 :param smtp_password: optional SMTP password to use, if mail_server_id is not passed
366 :param smtp_debug: optional SMTP debug flag, if mail_server_id is not passed366 :param smtp_debug: optional SMTP debug flag, if mail_server_id is not passed
367 :param debug: whether to turn on the SMTP level debugging, output to DEBUG log level
368 :return: the Message-ID of the message that was just sent, if successfully sent, otherwise raises367 :return: the Message-ID of the message that was just sent, if successfully sent, otherwise raises
369 MailDeliveryException and logs root cause.368 MailDeliveryException and logs root cause.
370 """369 """
371370
=== modified file 'openerp/tools/misc.py'
--- openerp/tools/misc.py 2012-02-08 17:28:25 +0000
+++ openerp/tools/misc.py 2012-03-06 17:36:39 +0000
@@ -3,7 +3,7 @@
3#3#
4# OpenERP, Open Source Management Solution4# OpenERP, Open Source Management Solution
5# Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).5# Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
6# Copyright (C) 2010 OpenERP s.a. (<http://openerp.com>).6# Copyright (C) 2010-2012 OpenERP s.a. (<http://openerp.com>).
7#7#
8# This program is free software: you can redistribute it and/or modify8# This program is free software: you can redistribute it and/or modify
9# it under the terms of the GNU Affero General Public License as9# it under the terms of the GNU Affero General Public License as
@@ -383,7 +383,7 @@
383383
384 res = mail_server_pool.send_email(cr, uid or 1, email_msg, mail_server_id=None,384 res = mail_server_pool.send_email(cr, uid or 1, email_msg, mail_server_id=None,
385 smtp_server=smtp_server, smtp_port=smtp_port, smtp_user=smtp_user, smtp_password=smtp_password,385 smtp_server=smtp_server, smtp_port=smtp_port, smtp_user=smtp_user, smtp_password=smtp_password,
386 smtp_encryption=('ssl' if ssl else None), debug=debug)386 smtp_encryption=('ssl' if ssl else None), smtp_debug=debug)
387 except Exception:387 except Exception:
388 _logger.exception("tools.email_send failed to deliver email")388 _logger.exception("tools.email_send failed to deliver email")
389 return False389 return False