Code review comment for lp:~openerp-dev/openobject-server/6.0-opw-6198-ira

Revision history for this message
Christophe Simonis (OpenERP) (kangol) wrote :

I know it's already merged in stable but this fix is broken.

In this case, the query doesn't bother me. On line 13 of the patch
>>> res = list(tuple(addr.values()) for addr in address_rec)
is completely false because the result of .values() is not guarantee to give the values in the same order for each dict. In this case, either you keep the query, either you use explicit fields via browse()

review: Needs Fixing

« Back to merge proposal