Code review comment for lp:~openerp-dev/openobject-server/6.0-opw-51167-ado

Revision history for this message
Xavier ALT (dex-phx) wrote :

Hi,

I will change this MP to "Need Review" as latest commit by Jean-Christophe was causing infinite loop when trying to render document with "internal header".

I've reworked that original fix. The standard report now handle PageCount() by himself. PageReset() flowable or "<pageNumberReset/>" within story now simply flag the document as "to be resetted", and we really reset the page number at each page end.

Please give your opinion on this,

Regards,
Xavier

« Back to merge proposal