Code review comment for lp:~openerp-dev/openobject-server/6.0-opw-17601-rgo

Revision history for this message
Anup(SerpentCS) (anup-serpent) wrote :

Hello Ravi,

I agree with you. I would definitely admit that any method which is being called by xmlrpc should not return None as 'None' is not being marshaled and raises an error.

I agree with your fix but I think won't be feasible to do it on a single method or it would require lot's of changes with other methods which are returning None.

So IMHO there should be some generic way to get rid of the issue. Whenever xmlrpc calls a method.

We still need to discuss with experts before merging it.

@Raphael,Olivier Can you please share your views?

Thanks.

« Back to merge proposal