Merge lp:~openerp-dev/openobject-client/6.0-opw-6168-ach into lp:openobject-client/6.0

Proposed by Anup(SerpentCS)
Status: Rejected
Rejected by: Olivier Dony (Odoo)
Proposed branch: lp:~openerp-dev/openobject-client/6.0-opw-6168-ach
Merge into: lp:openobject-client/6.0
Diff against target: 11 lines (+1/-0)
1 file modified
bin/rpc.py (+1/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-client/6.0-opw-6168-ach
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Disapprove
Naresh(OpenERP) Pending
Jay Vora (Serpent Consulting Services) Pending
Review via email: mp+65293@code.launchpad.net

Description of the change

Hello,

   When you restart postgres server you must restart the openerp server to connect to the database which was already connected. This seems to be annoying and not feasible. I have found a fix for the same.

  Kindly refer to https://code.launchpad.net/~openerp-dev/openobject-server/6.0-opw-6168-ach/+merge/65292 also.

Thanks.

To post a comment you must log in.
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Sorry, this does not seem like a valid approach.

Firstly, we should not rely on anything coming from the client side to solve a server-side issue, as OpenERP is supposed to be stateless.
Secondly, calling close_db has major and global effects on the server, impacting all transactions, so this certainly cannot be called as soon as someone logs out.

review: Disapprove

Unmerged revisions

1861. By Anup(SerpentCS)

[FIX] Connection : Connection need to be broken when postgres server is restarted

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/rpc.py'
2--- bin/rpc.py 2011-03-30 18:21:02 +0000
3+++ bin/rpc.py 2011-06-21 05:26:56 +0000
4@@ -374,6 +374,7 @@
5
6 def logout(self):
7 if self._open:
8+ self.rpc_exec_auth('/common', 'logout_db')
9 self._open = False
10 self.uname = None
11 self.uid = None