Merge lp:~openerp-dev/openobject-server/6.0-opw-6168-ach into lp:openobject-server/6.0

[Anup(SerpentCS)]

Hello,

   When Postgres server is restarted it is not possible to connect to the same db which was connected when the server was restarted. Even if the user disconnects.

   I have found a fix for such situation.

Thanks.

[Olivier Dony (Odoo) (odo-openerp)]

Sorry, this does not seem like a valid approach.

Firstly, we should not rely on anything coming from the client side to solve a server-side issue, as OpenERP is supposed to be stateless.
Secondly, calling exposing a way to close_db has major and global effects on the server, impacting all current transactions on that database, so this certainly cannot be called as soon as someone logs out.

Managing database connections is the responsibility of the server, it must not be exposed to clients, or for that matter, to addons.

review: Disapprove

[xrg (xrg)]

On Tuesday 21 June 2011, you wrote:

> When Postgres server is restarted it is not possible to connect to the
> same db which was connected when the server was restarted. Even if the
> user disconnects.
>
> I have found a fix for such situation.

I agree with Odo.

Allowing a remote close of all pg connections *without authentication* is a
straight remote DoS . Unacceptable.

Otoh, in pg84 branch, this problem had been fixed long ago.

--
Say NO to spam and viruses. Stop using Microsoft Windows!

Unmerged revisions

=== modified file 'bin/service/web_services.py'
--- bin/service/web_services.py	2011-01-15 17:04:10 +0000
+++ bin/service/web_services.py	2011-06-21 05:24:32 +0000
@@ -385,7 +385,7 @@
             return True
         elif method in ['about', 'timezone_get', 'get_server_environment',
                         'login_message','get_stats', 'check_connectivity',
-                        'list_http_services']:
+                        'list_http_services','logout_db']:
             pass
         elif method in ['get_available_updates', 'get_migration_scripts', 'set_loglevel', 'get_os_time', 'get_sqlcount']:
             passwd = params[0]
@@ -440,6 +440,9 @@
     def exp_timezone_get(self, db, login, password):
         return tools.misc.get_server_timezone()
 
+    def exp_logout_db(self, db, login, password):
+        return tools.misc.logout_db(db)
+
     def exp_get_available_updates(self, contract_id, contract_password):
         import tools.maintenance as tm
         try:

=== modified file 'bin/tools/misc.py'
--- bin/tools/misc.py	2011-01-20 12:40:20 +0000
+++ bin/tools/misc.py	2011-06-21 05:24:32 +0000
@@ -1264,6 +1264,11 @@
         ip_addr = 'localhost'
     return ip_addr
 
+def logout_db(db_name):
+    from sql_db import close_db
+    close_db(db_name)
+    return True
+
 # RATIONALE BEHIND TIMESTAMP CALCULATIONS AND TIMEZONE MANAGEMENT:
 #  The server side never does any timestamp calculation, always
 #  sends them in a naive (timezone agnostic) format supposed to be