Code review comment for lp:~openerp-dev/openobject-client-web/6.0-opw-583890-cpa

Revision history for this message
Xavier ALT (dex-phx) wrote :

Hi,

Commit is fine, but doesn't fix all use-cases:

Case 1:
=======
1a. Do steps 1), 2), 3) => button "Add" is disabled (so this is ok)
2a. Then clic on the column header "Name"

Observed: many2many widget is reloaded - but attrs seems to not be re-applied => widget still grey-out, but button is re-enabled.
Expected: both widget and button should be inactive.

Case 2:
=======
1a. Do steps 1), 2), 3) => button "Add" is disabled (so this is ok)
2a. Then try to remove one of the proposed default group (ex: Employee) from the many2many by clicking the cross "x"

Observed: item is really removed from the many2many
Expected: as readonly, we should not be able to remove item from the list.

Regards,
Xavier

review: Needs Fixing

« Back to merge proposal