Code review comment for lp:~openerp-dev/openobject-client-web/6.0-opw-5796-sma

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

The '/' prefix was added at the same time the conditional above was modified to add a 'split' in it.

I'm pretty sure if we go through conditional, things are going to break because there will not be a final '/' and so we'll get `somefield_terp_model` instead of `somefield/_terp_model`.

I think we need to leave it before `_terp_model` but remove adding of trailing '/' in original creation of `prefix`. What do you think?

review: Needs Fixing

« Back to merge proposal