Merge lp:~openerp-dev/openobject-client-web/6.0-opw-575059-cpa into lp:openobject-client-web

Proposed by Chirag Patel (OpenERP)
Status: Merged
Merged at revision: 4818
Proposed branch: lp:~openerp-dev/openobject-client-web/6.0-opw-575059-cpa
Merge into: lp:openobject-client-web
Diff against target: 21 lines (+3/-1)
1 file modified
addons/openerp/widgets/form/_m2m.py (+3/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-client-web/6.0-opw-575059-cpa
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+107762@code.launchpad.net

Description of the change

Hello,

Fixed domain not append when domain type unicode.

Demo: Sales > Sales > Sales Orders
1) Edit one Sales Orders.
2) Edit One Sales Order Lines.
3) Sort M2M 'Tax Name' column.

Observed: Error:"'unicode' object has no attribute 'append'".

Thanks.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/openerp/widgets/form/_m2m.py'
--- addons/openerp/widgets/form/_m2m.py 2012-03-19 09:43:24 +0000
+++ addons/openerp/widgets/form/_m2m.py 2012-05-29 12:03:20 +0000
@@ -30,7 +30,7 @@
30from openerp.widgets import register_widget30from openerp.widgets import register_widget
3131
32from openerp import validators32from openerp import validators
3333from openobject.tools import ast
3434
35__all__ = ["M2M"]35__all__ = ["M2M"]
3636
@@ -106,6 +106,8 @@
106 ids = ids[current.offset: current.offset+current.limit]106 ids = ids[current.offset: current.offset+current.limit]
107 107
108 if self.name == params.source and params.sort_key and ids:108 if self.name == params.source and params.sort_key and ids:
109 if isinstance(self.domain, basestring):
110 self.domain = ast.literal_eval(self.domain)
109 self.domain.append(('id', 'in', ids))111 self.domain.append(('id', 'in', ids))
110 limit = current.limit112 limit = current.limit
111 if current.limit == -1:113 if current.limit == -1: