Merge lp:~openerp-dev/openobject-addons/trunk-wizard_osv_memory_convert-uco into lp:openobject-addons

Proposed by Ujjvala Collins
Status: Superseded
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-wizard_osv_memory_convert-uco
Merge into: lp:openobject-addons
Diff against target: 109 lines (+5/-57)
3 files modified
account_asset/__openerp__.py (+4/-4)
account_asset/wizard/__init__.py (+1/-2)
account_asset/wizard/wizard_asset_close.py (+0/-51)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-wizard_osv_memory_convert-uco
Reviewer Review Type Date Requested Status
Raphael Collet (OpenERP) (community) Needs Fixing
Mustufa Rangwala (Open ERP) (community) Approve
Vo Minh Thu Pending
Review via email: mp+74158@code.launchpad.net

This proposal has been superseded by a proposal from 2011-10-19.

Description of the change

[IMP] account_asset:
----------------------------------
* Converted "Close Asset" wizard to osv_memory wizard. (Right now not used anywhere)

To post a comment you must log in.
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) :
review: Approve
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) :
review: Approve
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

I had a closer look at the module. Assets are closed with a button on their form, so the wizard is useless. It's dead, please remove it completely.

Thanks,
Raphael

review: Needs Fixing
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Never mind, I will do it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_asset/__openerp__.py'
--- account_asset/__openerp__.py 2011-10-11 14:03:35 +0000
+++ account_asset/__openerp__.py 2011-10-19 13:02:33 +0000
@@ -1,6 +1,6 @@
1# -*- encoding: utf-8 -*-1# -*- encoding: utf-8 -*-
2##############################################################################2##############################################################################
3# 3#
4# OpenERP, Open Source Management Solution4# OpenERP, Open Source Management Solution
5# Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).5# Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
6#6#
@@ -15,7 +15,7 @@
15# GNU Affero General Public License for more details.15# GNU Affero General Public License for more details.
16#16#
17# You should have received a copy of the GNU Affero General Public License17# You should have received a copy of the GNU Affero General Public License
18# along with this program. If not, see <http://www.gnu.org/licenses/>. 18# along with this program. If not, see <http://www.gnu.org/licenses/>.
19#19#
20##############################################################################20##############################################################################
2121
@@ -25,7 +25,7 @@
25 "depends" : ["account"],25 "depends" : ["account"],
26 "author" : "OpenERP S.A.",26 "author" : "OpenERP S.A.",
27 "description": """Financial and accounting asset management.27 "description": """Financial and accounting asset management.
28 This Module manages the assets owned by a company or an individual. It will keep track of depreciation's occurred on 28 This Module manages the assets owned by a company or an individual. It will keep track of depreciation's occurred on
29 those assets. And it allows to create Move's of the depreciation lines.29 those assets. And it allows to create Move's of the depreciation lines.
30 """,30 """,
31 "website" : "http://www.openerp.com",31 "website" : "http://www.openerp.com",
@@ -45,7 +45,7 @@
45 "account_asset_view.xml",45 "account_asset_view.xml",
46 "account_asset_invoice_view.xml",46 "account_asset_invoice_view.xml",
47 "report/account_asset_report_view.xml",47 "report/account_asset_report_view.xml",
48 48
49 ],49 ],
50 "active": False,50 "active": False,
51 "installable": True,51 "installable": True,
5252
=== modified file 'account_asset/wizard/__init__.py'
--- account_asset/wizard/__init__.py 2011-09-22 09:55:31 +0000
+++ account_asset/wizard/__init__.py 2011-10-19 13:02:33 +0000
@@ -18,9 +18,8 @@
18# along with this program. If not, see <http://www.gnu.org/licenses/>. 18# along with this program. If not, see <http://www.gnu.org/licenses/>.
19#19#
20##############################################################################20##############################################################################
21
21import account_asset_change_duration22import account_asset_change_duration
22import wizard_asset_compute23import wizard_asset_compute
23import wizard_asset_close
2424
25# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:25# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
26
2726
=== removed file 'account_asset/wizard/wizard_asset_close.py'
--- account_asset/wizard/wizard_asset_close.py 2011-09-22 09:55:31 +0000
+++ account_asset/wizard/wizard_asset_close.py 1970-01-01 00:00:00 +0000
@@ -1,51 +0,0 @@
1# -*- encoding: utf-8 -*-
2##############################################################################
3#
4# OpenERP, Open Source Management Solution
5# Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
6#
7# This program is free software: you can redistribute it and/or modify
8# it under the terms of the GNU Affero General Public License as
9# published by the Free Software Foundation, either version 3 of the
10# License, or (at your option) any later version.
11#
12# This program is distributed in the hope that it will be useful,
13# but WITHOUT ANY WARRANTY; without even the implied warranty of
14# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15# GNU Affero General Public License for more details.
16#
17# You should have received a copy of the GNU Affero General Public License
18# along with this program. If not, see <http://www.gnu.org/licenses/>.
19#
20##############################################################################
21
22import wizard
23import pooler
24
25asset_end_arch = '''<?xml version="1.0"?>
26<form string="Close asset">
27 <separator string="General information" colspan="4"/>
28</form>'''
29
30asset_end_fields = {
31}
32
33class wizard_asset_close(wizard.interface):
34 states = {
35 'init': {
36 'actions': [],
37 'result': {'type':'form', 'arch':asset_end_arch, 'fields':asset_end_fields, 'state':[
38 ('end','Cancel'),
39 ('asset_close','End of asset')
40 ]}
41 },
42 'asset_close': {
43 'actions': [],
44 'result': {'type' : 'state', 'state': 'end'}
45 }
46 }
47wizard_asset_close('account.asset.close')
48
49
50# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
51

Subscribers

People subscribed via source and target branches

to all changes: