Merge lp:~openerp-dev/openobject-addons/trunk-wizard_osv_memory_convert-uco into lp:openobject-addons

Proposed by Ujjvala Collins
Status: Superseded
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-wizard_osv_memory_convert-uco
Merge into: lp:openobject-addons
Diff against target: 109 lines (+5/-57)
3 files modified
account_asset/__openerp__.py (+4/-4)
account_asset/wizard/__init__.py (+1/-2)
account_asset/wizard/wizard_asset_close.py (+0/-51)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-wizard_osv_memory_convert-uco
Reviewer Review Type Date Requested Status
Raphael Collet (OpenERP) (community) Needs Fixing
Mustufa Rangwala (Open ERP) (community) Approve
Vo Minh Thu Pending
Review via email: mp+74158@code.launchpad.net

This proposal has been superseded by a proposal from 2011-10-19.

Description of the change

[IMP] account_asset:
----------------------------------
* Converted "Close Asset" wizard to osv_memory wizard. (Right now not used anywhere)

To post a comment you must log in.
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) :
review: Approve
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) :
review: Approve
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

I had a closer look at the module. Assets are closed with a button on their form, so the wizard is useless. It's dead, please remove it completely.

Thanks,
Raphael

review: Needs Fixing
Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

Never mind, I will do it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_asset/__openerp__.py'
2--- account_asset/__openerp__.py 2011-10-11 14:03:35 +0000
3+++ account_asset/__openerp__.py 2011-10-19 13:02:33 +0000
4@@ -1,6 +1,6 @@
5 # -*- encoding: utf-8 -*-
6 ##############################################################################
7-#
8+#
9 # OpenERP, Open Source Management Solution
10 # Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
11 #
12@@ -15,7 +15,7 @@
13 # GNU Affero General Public License for more details.
14 #
15 # You should have received a copy of the GNU Affero General Public License
16-# along with this program. If not, see <http://www.gnu.org/licenses/>.
17+# along with this program. If not, see <http://www.gnu.org/licenses/>.
18 #
19 ##############################################################################
20
21@@ -25,7 +25,7 @@
22 "depends" : ["account"],
23 "author" : "OpenERP S.A.",
24 "description": """Financial and accounting asset management.
25- This Module manages the assets owned by a company or an individual. It will keep track of depreciation's occurred on
26+ This Module manages the assets owned by a company or an individual. It will keep track of depreciation's occurred on
27 those assets. And it allows to create Move's of the depreciation lines.
28 """,
29 "website" : "http://www.openerp.com",
30@@ -45,7 +45,7 @@
31 "account_asset_view.xml",
32 "account_asset_invoice_view.xml",
33 "report/account_asset_report_view.xml",
34-
35+
36 ],
37 "active": False,
38 "installable": True,
39
40=== modified file 'account_asset/wizard/__init__.py'
41--- account_asset/wizard/__init__.py 2011-09-22 09:55:31 +0000
42+++ account_asset/wizard/__init__.py 2011-10-19 13:02:33 +0000
43@@ -18,9 +18,8 @@
44 # along with this program. If not, see <http://www.gnu.org/licenses/>.
45 #
46 ##############################################################################
47+
48 import account_asset_change_duration
49 import wizard_asset_compute
50-import wizard_asset_close
51
52 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
53-
54
55=== removed file 'account_asset/wizard/wizard_asset_close.py'
56--- account_asset/wizard/wizard_asset_close.py 2011-09-22 09:55:31 +0000
57+++ account_asset/wizard/wizard_asset_close.py 1970-01-01 00:00:00 +0000
58@@ -1,51 +0,0 @@
59-# -*- encoding: utf-8 -*-
60-##############################################################################
61-#
62-# OpenERP, Open Source Management Solution
63-# Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
64-#
65-# This program is free software: you can redistribute it and/or modify
66-# it under the terms of the GNU Affero General Public License as
67-# published by the Free Software Foundation, either version 3 of the
68-# License, or (at your option) any later version.
69-#
70-# This program is distributed in the hope that it will be useful,
71-# but WITHOUT ANY WARRANTY; without even the implied warranty of
72-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
73-# GNU Affero General Public License for more details.
74-#
75-# You should have received a copy of the GNU Affero General Public License
76-# along with this program. If not, see <http://www.gnu.org/licenses/>.
77-#
78-##############################################################################
79-
80-import wizard
81-import pooler
82-
83-asset_end_arch = '''<?xml version="1.0"?>
84-<form string="Close asset">
85- <separator string="General information" colspan="4"/>
86-</form>'''
87-
88-asset_end_fields = {
89-}
90-
91-class wizard_asset_close(wizard.interface):
92- states = {
93- 'init': {
94- 'actions': [],
95- 'result': {'type':'form', 'arch':asset_end_arch, 'fields':asset_end_fields, 'state':[
96- ('end','Cancel'),
97- ('asset_close','End of asset')
98- ]}
99- },
100- 'asset_close': {
101- 'actions': [],
102- 'result': {'type' : 'state', 'state': 'end'}
103- }
104- }
105-wizard_asset_close('account.asset.close')
106-
107-
108-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
109-

Subscribers

People subscribed via source and target branches

to all changes: