Code review comment for lp:~openerp-dev/openobject-addons/trunk-timeuomprojecttasks-jco

Revision history for this message
qdp (OpenERP) (qdp) wrote :

> It needs some fixing/explanation:
>
> 1) line 15: you removed widget="float_time", but it seems that 'hours' is
> still the default uom for project management, and if you do things like:
> 52 + if hours:
> 53 + return res
> then it means that you should leave the float_time widget, no?
>
> 2) please add some comments + docstrings in the fields_view_get inheritance to
> explain what's done there
>
> 3) it seems that the same function is duplicated 3 times. Can you make a
> generic function that will be use 3 times with the model as extra_parameter
> instead? Factorizing the code is good :-)
>
> that's all i can think of, so far.

« Back to merge proposal