Code review comment for lp:~openerp-dev/openobject-addons/trunk-signature-jsh

Revision history for this message
Thibault Delavallée (OpenERP) (tde-openerp) wrote :

Hello,

You should grep signature and all addons and see if your change has an impact.

Notably, I would like you to check the following things :
- account_followup/report/account_followup_print.py: uses user signature -> how does it behave with html tags and things like that ?
- hr_evaluation/hr_evaluation.py: user signature seems to be used, so same question
- crm_partner_assign/crm_partner_assign_data.xml: user signature is used in a pre, it wlil give some strange result

Best regards,

review: Needs Fixing (technical)

« Back to merge proposal