Code review comment for lp:~openerp-dev/openobject-addons/trunk-payment-buckaroo-dka

Hello,

Some remarks :
- remove credentials from data now that the branch is about to be merged (set dummy / dummy)
- lint the module (some unused imports, space errors, ...)

One thing to add :
- management of tx_values['return_url'] (see in paypal / adyen / ...). Using custom variables (see chapter about custom variables in buckaroo documentation), put the return url of the shop like other providers, and get it back in the controller instead of having an hardcoded redirection to "/shop/payment/validate/" .

Best regards,

Thibault.