Code review comment for lp:~openerp-dev/openobject-addons/trunk-new-account-tax-design-tpa

REALLY thanks.

I can't find an important point (and I think it should be done in the core because overwrite taxes is really complex technically speaking).

In Odoo (formelly OpenERP) for historical reasons the VAT is applied on "Invoices" directly to "Income and Outcome Tax." AFAICS it will continue being on this way, but, we have several countries (Mexico, EEUU, Italy AFAICK) where we have 2 stages for every account.tax on invoices:

1.- Tax Invoiced.
2.- Tax effectively paid.

The first one is perfectly managed by the actual behavior even on this merge proposal.

But the second one (which the payment process must to be included) is not possible, then we have in the pad one question not answered yet:

----
Question... (that wait for an answer)
does it make sense to be able to add lines in Journal items ?
----

May be if the answer is "Yes" it can help but I am not sure that it is the correct approach (due to the great simplification done on the configuration process that can be solved in a different way).

We did this approach in a generic way[1] (but so tricky due to technical limitations on this module as it is actually) but We think the concept is clear, we need at least 2 extra accounts on taxes (see the code) on account.tax and account.tax.template models.

It means, if you think this concept of separate "Invoiced" from "Paid" taxes in a configurable way can be included on the core we can document perfectly this module and share all documentation regarding with the "Functional" approach (because honestly I am not ABSOLUTLY SURE if our technical approach was correct, but we are absolutely sure functionally speaking it is a mandatory feature on some countries).

Thanks in advance and again, thanks for this improvements.

[1] http://goo.gl/rj5fDa