Code review comment for lp:~openerp-dev/openobject-addons/trunk-bug-997141-cha

Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

Hello ajay,

I don't think this code is working fine.

we need not to check a condition if posted_depreciation_line_ids: inside for x in range(len(posted_depreciation_line_ids), undone_dotation_number):

line 18 of your patch seems too static as is will always check for the index [0]!!

Please update your branch with latest trunk :)

Thanks,
Purnendu Singh

review: Needs Fixing

« Back to merge proposal