Merge lp:~openerp-dev/openobject-addons/trunk-bug-956234-amp into lp:openobject-addons

Proposed by Amit Parik
Status: Rejected
Rejected by: Olivier Dony (Odoo)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-956234-amp
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
procurement/schedulers.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-956234-amp
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Disapprove
Review via email: mp+98401@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hello Amit,

We should not create duplicate merge proposals when there is one already from the community that is doing the same thing :-)
Here we already have a branch from Guewen, it's simpler to directly merge it if we want to credit him fully, rather than trying to do the work again and commit using --author. I will merge Guewen's branch to close the bug.

Thanks!

review: Disapprove

Unmerged revisions

6680. By Guewen

[FIX] procurment : Fix the read method problem

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'procurement/schedulers.py'
--- procurement/schedulers.py 2012-01-31 13:36:57 +0000
+++ procurement/schedulers.py 2012-03-20 13:07:22 +0000
@@ -267,7 +267,7 @@
267 if op.procurement_draft_ids:267 if op.procurement_draft_ids:
268 # Check draft procurement related to this order point268 # Check draft procurement related to this order point
269 pro_ids = [x.id for x in op.procurement_draft_ids]269 pro_ids = [x.id for x in op.procurement_draft_ids]
270 procure_datas = procurement_obj.read(cr, uid, pro_ids, ['id','product_qty'], context=context, order='product_qty desc')270 procure_datas = procurement_obj.read(cr, uid, pro_ids, ['id','product_qty'], context=context)
271 to_generate = qty271 to_generate = qty
272 for proc_data in procure_datas:272 for proc_data in procure_datas:
273 if to_generate >= proc_data['product_qty']:273 if to_generate >= proc_data['product_qty']:

Subscribers

People subscribed via source and target branches

to all changes: