Merge lp:~openerp-dev/openobject-addons/trunk-bug-924200-mdi into lp:openobject-addons

Proposed by DJ Patel (OpenERP)
Status: Rejected
Rejected by: Raphael Collet (OpenERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-924200-mdi
Merge into: lp:openobject-addons
Diff against target: 20 lines (+9/-1)
1 file modified
account/demo/account_demo.xml (+9/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-924200-mdi
Reviewer Review Type Date Requested Status
Raphael Collet (OpenERP) (community) Disapprove
Review via email: mp+91058@code.launchpad.net

Description of the change

Hello Sir,

I have fix the issue: https://bugs.launchpad.net/openobject-addons/+bug/924200 "account demo data - wrong period's definition for field special".

Thanks and Regards,

Divyesh Makwana(MDI)

To post a comment you must log in.
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Hello,

Thought it improves a bit the current state, this doesn't fix the bug implied by the hack of using special field in demo periods.

A deeper fix is needed for that.

Regards,
Yannick

Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

This merge proposal does not actually serve any purpose, so I will reject it.
We will not fix the bug. The rationale is that the demo data should not prevent to recreate periods for the current fiscal year.

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account/demo/account_demo.xml'
--- account/demo/account_demo.xml 2012-01-31 13:36:57 +0000
+++ account/demo/account_demo.xml 2012-02-01 11:54:47 +0000
@@ -17,7 +17,15 @@
17 <!--17 <!--
18 Fiscal Periods18 Fiscal Periods
19 --> 19 -->
20 20 <record id="period_0" model="account.period">
21 <field eval="'00/'+time.strftime('%Y')" name="code"/>
22 <field eval="'X Opening Period'+time.strftime('%Y')" name="name"/>
23 <field eval="True" name="special"/>
24 <field name="fiscalyear_id" ref="data_fiscalyear"/>
25 <field eval="time.strftime('%Y')+'-01-01'" name="date_start"/>
26 <field eval="time.strftime('%Y')+'-01-01'" name="date_stop"/>
27 <field name="company_id" ref="base.main_company"/>
28 </record>
21 <record id="period_1" model="account.period">29 <record id="period_1" model="account.period">
22 <field eval="'01/'+time.strftime('%Y')" name="code"/>30 <field eval="'01/'+time.strftime('%Y')" name="code"/>
23 <field eval="'X 01/'+time.strftime('%Y')" name="name"/>31 <field eval="'X 01/'+time.strftime('%Y')" name="name"/>

Subscribers

People subscribed via source and target branches

to all changes: