Code review comment for lp:~openerp-dev/openobject-addons/trunk-bug-879295-kjo

Hi Bhumika, thanks for giving more details, but I'm not sure I understand your comment.

The original branch attached to the bug report contains changes for the PO[T] files *and* changes to the button and label. Changing the PO files only would make no sense of course.
So if I merge KJO 's branch after merging the branch from Serpent CS I get no diff at all, because it was all done already (just tried it).

You can compare the 2 revisions, committed at 2 hours of difference: [1] and [2]

Also this branch's description does not say that it fixes something that was supposedly missing in the original merge proposal, and does not have the --fixes lp:# flag. BTW, if something was missing it could have been mentioned on the review of the contributed branch :-)

So unless you think something is really missing, we can consider this branch and merge proposal rejected, as everything is already provided by Serpent's branch.

Do not hesitate to correct me if I'm wrong of course! :-)

Thanks!

[1] http://bazaar.launchpad.net/~serpent-consulting-services/openobject-addons/trunk-survey-typo-corrections/revision/5434
[2] http://bazaar.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-879295-kjo/revision/5434