Code review comment for lp:~openerp-dev/openobject-addons/trunk-bug-879295-kjo

I agree with Serpent CS, whenever possible we should merge the proposed contribution by the community, instead of copying them and risking to forget properly crediting the patch to them.
If necessary and having no time to wait for the community to fix any issue in the merge prop, we can always merge their branch into a temporary branch in which we fix the last details, and then merge that in trunk, keeping all the history and credit.

You apparently lost matching changes in the PO files, and you also forgot to properly tag the commit with --fixes lp:879295, losing a precious link with the bug. As a result, your merge proposal is not linked on the bug right now, making people think the Fix Committed version is the one from Serpent CS, ironically.

Please be careful with this in the future - I'm rejecting this merge, we can directly process the one from the community.