Code review comment for lp:~openerp-dev/openobject-addons/trunk-bug-872227-bde

Purnendu,

Your opinion is as clear as a crystal.

I now see that the bug was already there and has been set as a duplicate where Bharat already fixed with same patch.

Henceforth, the proposal from Bharat should be given a priority undoubtedly.

Being a little strict about the technical/programmatic/philosophic/conventional manner, there is a difference in the patches.

The proposal from Bharat shows the line "to_char(s.date_order, 'YYYY') as year" after the day, which is not the right order if you see the _columns definition. It should be before month.

We prefer to respect the sequence and logical importance of the proposal and so; Bharat's proposal should go for the merge and if you consider my request of ordering of columns,the line should be taken from my proposal.

Thanks a lot for bringing this into notice,
Serpent Consulting Services.