Code review comment for lp:~openerp-dev/openobject-addons/trunk-bug-862227-dbr

Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

1. google_map has already been adapted, see by https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-google_map_wizard-bde/+merge/73215. Please cancel your changes about google_map.

2. The modifications in module share has nothing to do in this merge proposal. Please revert, and make a specific proposal for this one, if needed.

3. base_module_quality is broken. Please check model names, and fix them:

[2011-11-28 14:51:42,179][trunk_20111128] INFO:init.load:module base_module_quality: loading wizard/module_quality_check_view.xml
[2011-11-28 14:51:42,211][trunk_20111128] ERROR:tools.convert.xml_import:Parse error in /home/openerp/openerp/addons/trunk/base_module_quality/wizard/module_quality_check_view.xml:29:
<act_window name="Quality Check" id="act_base_module_quality" res_model="quality.check" src_model="ir.module.module" view_mode="form" target="new" key2="client_action_multi"/>
Traceback (most recent call last):
  File "/home/openerp/openerp/server/trunk/openerp/tools/convert.py", line 889, in parse
    self._tags[rec.tag](self.cr, rec, n)
  File "/home/openerp/openerp/server/trunk/openerp/tools/convert.py", line 523, in _tag_act_window
    id = self.pool.get('ir.model.data')._update(cr, self.uid, 'ir.actions.act_window', self.module, res, xml_id, noupdate=self.isnoupdate(data_node), mode=self.mode)
  File "/home/openerp/openerp/server/trunk/openerp/addons/base/ir/ir_model.py", line 692, in _update
    model_obj.write(cr, uid, [res_id], values, context=context)
  File "/home/openerp/openerp/server/trunk/openerp/osv/orm.py", line 3905, in write
    self._validate(cr, user, ids, context)
  File "/home/openerp/openerp/server/trunk/openerp/osv/orm.py", line 1431, in _validate
    raise except_orm('ValidateError', '\n'.join(error_msgs))
except_orm: ('ValidateError', 'Error occurred while validating the field(s) res_model,src_model: Invalid model name in the action definition.')
[2011-11-28 14:51:42,218][trunk_20111128] INFO:werkzeug:127.0.0.1 - - [28/Nov/2011 14:51:42] "POST /web/dataset/call_button HTTP/1.1" 200 -

review: Needs Fixing

« Back to merge proposal