Code review comment for lp:~openerp-dev/openobject-addons/trunk-bug-827649-bde

Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

1) if there isn't any change in account_move_line.py then why it is in your patch!!!!

2) in your patch line 91
    + voucher_brw = self.pool.get('account.voucher').browse(cr,uid,voucher_id,context=context)
    * please make a habit of pooling all required objects at the start of the method
    * browse(cr,uid,voucher_id,context=context)..... we generally using a space between each arguments
3) line 137 to 159 it can be optimize. there are too many variables used!!!! Improve this

review: Needs Fixing

« Back to merge proposal