Code review comment for lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp

Revision history for this message
xrg (xrg) wrote :

On Tuesday 19 April 2011, you wrote:
> qdp (OpenERP) has proposed merging
> lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into
> lp:openobject-addons.
>
> Requested reviews:
> Olivier Dony (OpenERP) (odo)
> Related bugs:
> Bug #744789 in OpenERP Addons: "[V6] Third party ledger : Initial
> Balance" https://bugs.launchpad.net/openobject-addons/+bug/744789
>
> For more details, see:
> https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-
> qdp/+merge/58334
>
> in the query_get() of account.move.line, if we don't give any other
> criteria in the context than the fiscalyear when computing an initial
> balance then it simply means that the entries returned will be exactly the
> same as without initial balance, which lead to count the entries twice...
>
> this hack is a little nasty (not so say "a lot nasty"), but i can't think
> to something else.

you could use "AND false"

But I'm trying to think if a direct exception would also make sense in that
case.

--
Say NO to spam and viruses. Stop using Microsoft Windows!

« Back to merge proposal