Merge lp:~openerp-dev/openobject-addons/trunk-bug-1136373-priyanka into lp:openobject-addons

Proposed by Priyanka Jani(OpenERP Trainee)
Status: Superseded
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1136373-priyanka
Merge into: lp:openobject-addons
Diff against target: 14 lines (+1/-3)
1 file modified
account/account_bank_statement.py (+1/-3)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1136373-priyanka
Reviewer Review Type Date Requested Status
Amit Parik (community) Needs Fixing
OpenERP Core Team Pending
Review via email: mp+152329@code.launchpad.net

This proposal has been superseded by a proposal from 2013-03-08.

Description of the change

Hello,

Issue:Wrong currency on bank statement in multi company setup

This issue is fixes.

Thanks,
priyanka

To post a comment you must log in.
Revision history for this message
Amit Parik (amit-parik) wrote :

Its not proper.

You have to use like this.
currency = statement.journal_id.currency or statement.journal_id.company_id.currency_id

this is the better.

review: Needs Fixing
8600. By Priyanka Jani(OpenERP Trainee)

[IMP]:add currency of journal_id

8601. By Priyanka Jani(OpenERP Trainee)

[MERGE] with trunk

Unmerged revisions

8601. By Priyanka Jani(OpenERP Trainee)

[MERGE] with trunk

8600. By Priyanka Jani(OpenERP Trainee)

[IMP]:add currency of journal_id

8599. By Priyanka Jani(OpenERP Trainee)

[FIX]:addons:Wrong currency on bank statement in multi company setup

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account/account_bank_statement.py'
--- account/account_bank_statement.py 2012-12-20 11:54:56 +0000
+++ account/account_bank_statement.py 2013-03-08 09:08:21 +0000
@@ -73,9 +73,7 @@
73 default_currency = res_users_obj.browse(cursor, user,73 default_currency = res_users_obj.browse(cursor, user,
74 user, context=context).company_id.currency_id74 user, context=context).company_id.currency_id
75 for statement in self.browse(cursor, user, ids, context=context):75 for statement in self.browse(cursor, user, ids, context=context):
76 currency = statement.journal_id.currency76 currency = statement.journal_id.currency or statement.journal_id.company_id.currency_id
77 if not currency:
78 currency = default_currency
79 res[statement.id] = currency.id77 res[statement.id] = currency.id
80 currency_names = {}78 currency_names = {}
81 for currency_id, currency_name in res_currency_obj.name_get(cursor,79 for currency_id, currency_name in res_currency_obj.name_get(cursor,

Subscribers

People subscribed via source and target branches

to all changes: