Merge lp:~openerp-dev/openobject-addons/trunk-bug-1103072-ishwar into lp:openobject-addons

Proposed by Ishwar Malvi(OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1103072-ishwar
Merge into: lp:openobject-addons
Diff against target: 44 lines (+15/-3)
2 files modified
survey/security/survey_security.xml (+10/-0)
survey/wizard/survey_send_invitation.py (+5/-3)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1103072-ishwar
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) (community) Disapprove
OpenERP Core Team Pending
Review via email: mp+154662@code.launchpad.net

Description of the change

Hello,

      I have fixed a problem of survey : survey invited user can't able to answer survey.

Thanks,
Ishwar Malvi

To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

We feel that this change is granting too broad permissions to the invited respondents. My colleague Holger proposes a more refined change here:

https://code.launchpad.net/~therp-nl/openobject-addons/7.0_make_survey_module_usable_for_external_users/+merge/180328

review: Disapprove

Unmerged revisions

8639. By Ishwar Malvi(OpenERP)

[FIX] survey : In Survey Invitations invited user can't view survey

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'survey/security/survey_security.xml'
--- survey/security/survey_security.xml 2012-04-04 09:08:30 +0000
+++ survey/security/survey_security.xml 2013-03-21 10:57:43 +0000
@@ -16,4 +16,14 @@
16 <field name="users" eval="[(4, ref('base.user_root'))]"/>16 <field name="users" eval="[(4, ref('base.user_root'))]"/>
17 </record>17 </record>
18 </data>18 </data>
19 <data noupdate="1">
20 <record id="survey_rule" model="ir.rule">
21 <field name="name">Survey</field>
22 <field name="model_id" ref="model_survey" />
23 <field name="global" eval="True" />
24 <field name="domain_force">
25 [('invited_user_ids', '=', user.id)]
26 </field>
27 </record>
28 </data>
19</openerp>29</openerp>
2030
=== modified file 'survey/wizard/survey_send_invitation.py'
--- survey/wizard/survey_send_invitation.py 2012-12-06 14:56:32 +0000
+++ survey/wizard/survey_send_invitation.py 2013-03-21 10:57:43 +0000
@@ -108,8 +108,10 @@
108 mail_message = self.pool.get('mail.message')108 mail_message = self.pool.get('mail.message')
109109
110 model_data_obj = self.pool.get('ir.model.data')110 model_data_obj = self.pool.get('ir.model.data')
111 group_id = model_data_obj._get_id(cr, uid, 'base', 'group_survey_user')111 group_id1= model_data_obj._get_id(cr, uid, 'base', 'group_survey_user')
112 group_id = model_data_obj.browse(cr, uid, group_id, context=context).res_id112 group_id1 = model_data_obj.browse(cr, uid, group_id1, context=context).res_id
113 group_id2= model_data_obj._get_id(cr, uid, 'base', 'group_tool_manager')
114 group_id2 = model_data_obj.browse(cr, uid, group_id2, context=context).res_id
113115
114 act_id = self.pool.get('ir.actions.act_window')116 act_id = self.pool.get('ir.actions.act_window')
115 act_id = act_id.search(cr, uid, [('res_model', '=' , 'survey.name.wiz'), \117 act_id = act_id.search(cr, uid, [('res_model', '=' , 'survey.name.wiz'), \
@@ -186,7 +188,7 @@
186 'login': partner.email,188 'login': partner.email,
187 'password': passwd,189 'password': passwd,
188 'address_id': partner.id,190 'address_id': partner.id,
189 'groups_id': [[6, 0, [group_id]]],191 'groups_id': [[6, 0, [group_id1,group_id2]]],
190 'action_id': act_id[0],192 'action_id': act_id[0],
191 'survey_id': [[6, 0, survey_ids]]193 'survey_id': [[6, 0, survey_ids]]
192 }194 }

Subscribers

People subscribed via source and target branches

to all changes: