Merge lp:~openerp-dev/openobject-addons/trunk-bug-1059561-nco into lp:openobject-addons

Proposed by Nimesh Contractor(Open ERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1059561-nco
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
plugin/plugin_handler.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1059561-nco
Reviewer Review Type Date Requested Status
Thibault Delavallée (OpenERP) (community) Needs Fixing
Atul Patel(OpenERP) (community) Approve
Review via email: mp+129612@code.launchpad.net

Description of the change

Hello,

      I have improve the search string for creating partner in plugin.

Thanks,
 NCO.

To post a comment you must log in.
Revision history for this message
Atul Patel(OpenERP) (atp-openerp) wrote :

Hello

seems work

Thanks for fix

review: Approve
Revision history for this message
Thibault Delavallée (OpenERP) (tde-openerp) wrote :

Hello,

I would find it very interesting to have a test case (yml or python, as you want, but to be honest, I prefer to review python :p) with this merge prop, that crashes without the bug fix, and that passes with it.

Best regards,

review: Needs Fixing

Unmerged revisions

7780. By Nimesh Contractor(Open ERP)

[IMP] improve the search string for creating a partner.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugin/plugin_handler.py'
--- plugin/plugin_handler.py 2012-10-02 10:29:15 +0000
+++ plugin/plugin_handler.py 2012-10-15 06:56:21 +0000
@@ -26,7 +26,7 @@
2626
27 def partner_get(self, cr, uid, address_email):27 def partner_get(self, cr, uid, address_email):
28 partner_obj = self.pool.get('res.partner')28 partner_obj = self.pool.get('res.partner')
29 partner_ids = partner_obj.search(cr, uid, [('email', 'like', address_email)])29 partner_ids = partner_obj.search(cr, uid, [('email', '=', address_email)])
30 res_id = partner_ids and partner_ids[0] or 030 res_id = partner_ids and partner_ids[0] or 0
31 url = self._make_url(cr, uid, res_id, 'res.partner')31 url = self._make_url(cr, uid, res_id, 'res.partner')
32 return ('res.partner', res_id , url)32 return ('res.partner', res_id , url)

Subscribers

People subscribed via source and target branches

to all changes: