Code review comment for lp:~openerp-dev/openobject-addons/trunk-bug-1038938-mdi

Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

Seems ok and it fixes 3 issues:

1) First issue is fixed from by updating the name_get method of account_journal object.

2) Once the first issue is fixed there was another problem b'coz client was sending journal_ and period_ as str instead of int. So, we need to update the convert_to_int method so it will return journal and period id in integer.

3) Wizard was not showing Journal and period details in proper formate!! We updated that one also

Thanks,
Purnendu Singh

review: Approve

« Back to merge proposal