Code review comment for lp:~openerp-dev/openobject-addons/trunk-account_cash_flow-jap

Hello,

I don' get the point with this 'is_visible' field... you do this thing only to hide debit_credit field on the wizard for a particular report ? This seems very specific to me and I am not sure we should keep it in the code. I think just adding a default_debit_credit value when invoking the wizard in action_account_report_cf action should be sufficient to have correct default values without adding fields and on_change for a specific report.

Also, please respect what seems to be a convention in account_financial_report_data.xml file:, they seems to all begin by account_financial_report_... .

Best regards,

Thibault.