Merge lp:~openerp-dev/openobject-addons/7.0-opw-606423-han into lp:openobject-addons/7.0

[Hardik Ansodariya (OpenERP)]

The loop in do_change_standard_price used to re-browse the product record based on the location context.

Create a product, average stock valuation and real time accounting.
Let's assume 2 internal locations - Output and Stock
Output has quantity of zero
 Stock has quantity of 10.
Go to product maintenance and click "- update" to update the cost.

It creates journal entries with # of internal location even if quantity is 0.

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello,

Thanks for your fix but actually I prefer to avoid recreating a full browse record (and refetching unchanged values in the database).
Instead I have fixed it using a read to the qty_available field only. This allows to keep a global browse in the for loop.
It was merged in 7.0 at revision 10023.

Unmerged revisions

9912. By Hardik Ansodariya (OpenERP) on 2014-04-10

[FIXED] stock/product.py: Fixed the issue of duplicate journal entries with # of location when updating cost price of product(Maintenace: 606423)

=== modified file 'stock/product.py'
--- stock/product.py	2014-01-21 12:42:43 +0000
+++ stock/product.py	2014-04-10 06:54:13 +0000
@@ -92,7 +92,8 @@
         journal_id = datas.get('stock_journal', False)
         move_ids = []
         loc_ids = location_obj.search(cr, uid,[('usage','=','internal')])
-        for product in self.browse(cr, uid, ids, context=context):
+        product = self.browse(cr, uid, ids, context=context)[0]
+        for rec_id in ids:
             if product.valuation != 'real_time':
                 continue
             account_valuation = product.categ_id.property_stock_valuation_account_id
@@ -104,7 +105,7 @@
                     'location': location.id,
                     'compute_child': False
                 })
-
+                product = self.browse(cr, uid, rec_id, context=c)
                 qty = product.qty_available
                 diff = product.standard_price - new_price
                 if not diff: raise osv.except_osv(_('Error!'), _("No difference between standard price and new price!"))