Code review comment for lp:~openerp-dev/openobject-addons/7.0-opw-597492-pna

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Hello just a remark about credits.

As this branche was made (2013-09-24) after mine was proposed (2013-09-04) and I can see my own changes a little line about authoring would be much appreciated.

https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1220732

I agree there was few improvement that I will synchronize on ocb-addons MP but part of this change was done by me. At least the 'Courtesy of' in commit message would be appreciated ... And much better would be a commit with my actual patch with correct --author parameters and a second with the changes made by you.

review: Needs Fixing

« Back to merge proposal