Merge lp:~openerp-dev/openobject-addons/7.0-opw-590663-rmu into lp:openobject-addons/7.0

Proposed by Ravish(OpenERP)
Status: Merged
Merged at revision: 9210
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-opw-590663-rmu
Merge into: lp:openobject-addons/7.0
Diff against target: 47 lines (+25/-1)
2 files modified
account/account_invoice.py (+1/-1)
account/i18n/account.pot (+24/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-opw-590663-rmu
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Needs Fixing
Naresh(OpenERP) Pending
Review via email: mp+164068@code.launchpad.net

Description of the change

Hello,

I have improved translation of journal in company_on_change.
when you change company, it will shown journal name in osv exception in user language.

Thanks lot..!!

To post a comment you must log in.
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Some problems that I will fix while merging:
- Changing the POT files to add terms that are not automatically found by our extractor is not a good idea, because they will be dropped later. You need to make sure that they are properly found
- Asking translators to translate the technical name of Journal Types is not a good idea either, you should use the label of the type
- The whole fix is useless because this onchange method does not receive a context, and we cannot add it in a stable series. We can workaround this problem by adding a fake context within the onchange, until the API can be fixed in the future.

Thanks

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account/account_invoice.py'
--- account/account_invoice.py 2013-04-18 15:40:22 +0000
+++ account/account_invoice.py 2013-05-16 05:35:54 +0000
@@ -614,7 +614,7 @@
614 if r[1] == 'journal_id' and r[2] in journal_ids:614 if r[1] == 'journal_id' and r[2] in journal_ids:
615 val['journal_id'] = r[2]615 val['journal_id'] = r[2]
616 if not val.get('journal_id', False):616 if not val.get('journal_id', False):
617 raise osv.except_osv(_('Configuration Error!'), (_('Cannot find any account journal of %s type for this company.\n\nYou can create one in the menu: \nConfiguration\Journals\Journals.') % (journal_type)))617 raise osv.except_osv(_('Configuration Error!'), (_('Cannot find any account journal of %s type for this company.\n\nYou can create one in the menu: \nConfiguration\Journals\Journals.') % _(journal_type)))
618 dom = {'journal_id': [('id', 'in', journal_ids)]}618 dom = {'journal_id': [('id', 'in', journal_ids)]}
619 else:619 else:
620 journal_ids = obj_journal.search(cr, uid, [])620 journal_ids = obj_journal.search(cr, uid, [])
621621
=== modified file 'account/i18n/account.pot'
--- account/i18n/account.pot 2013-03-07 12:19:34 +0000
+++ account/i18n/account.pot 2013-05-16 05:35:54 +0000
@@ -16,6 +16,30 @@
16"Plural-Forms: \n"16"Plural-Forms: \n"
1717
18#. module: account18#. module: account
19#: code:addons/account/account_invoice.py:601
20#, python-format
21msgid "sale"
22msgstr ""
23
24#. module: account
25#: code:addons/account/account_invoice.py:603
26#, python-format
27msgid "sale_refund"
28msgstr ""
29
30#. module: account
31#: code:addons/account/account_invoice.py:605
32#, python-format
33msgid "purchase_refund"
34msgstr ""
35
36#. module: account
37#: code:addons/account/account_invoice.py:607
38#, python-format
39msgid "purchase"
40msgstr ""
41
42#. module: account
19#: model:process.transition,name:account.process_transition_supplierreconcilepaid043#: model:process.transition,name:account.process_transition_supplierreconcilepaid0
20msgid "System payment"44msgid "System payment"
21msgstr ""45msgstr ""