Code review comment for lp:~openerp-dev/openobject-addons/7.0-opw-590221

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hi Jigar,

Seems a cool fix ! Such a trap was not cached before where conversion being on a field type of different nature.

However few improvements I feel we should do !

It will be nice if we make this method in general so that any one can use it easily. Say we can define this in
server/openerp/tools/misc.py and then can be accessed where ever its needed. This will reduce code duplicity too.

*Usability* : we can improve a bit the help text added or can have community opinion on this !

*Supplier Order*:

This is the leads/security time for each purchase order. For company security purpose this many days will be removed from the date what suppliers has promised to you.

*Customer Order*:

For company security purpose this many days will be removed from the date, what you have promised to customers,
to cope up with any problems of procurement, final shipping, order negotiation etc.

Thanks,
Naresh Soni
OpenERP Enterprise Services

review: Needs Fixing

« Back to merge proposal