Merge lp:~openerp-dev/openobject-addons/7.0-opw-587622-mma into lp:openobject-addons/7.0

Proposed by Mayur Maheshwari(OpenERP)
Status: Work in progress
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-opw-587622-mma
Merge into: lp:openobject-addons/7.0
Diff against target: 26 lines (+5/-5)
1 file modified
account_followup/account_followup_customers.xml (+5/-5)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-opw-587622-mma
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Needs Fixing
Review via email: mp+152393@code.launchpad.net

Description of the change

Hello

Go to Sale,In search view Group By.. label is displayed two times

This branch fix this isse

Thanks
Mayur

To post a comment you must log in.
Revision history for this message
Csaba TOTH (tsabi) wrote :

Just a small suggestion: at line 22 you can use "'" instead of """. It will be more readable:

<xpath expr="//filter[@string='Country']" position="after">

thanks,
Csaba

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hi Mayur,

The diff should be improved for readability as stated by Csaba TOTH.

Thanks,
Naresh Soni
OpenERP Enterprise Services

review: Needs Fixing

Unmerged revisions

8828. By Mayur Maheshwari(OpenERP)

[FIX]account_followup: set serch view fix duplicate group by

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_followup/account_followup_customers.xml'
--- account_followup/account_followup_customers.xml 2013-02-26 15:28:03 +0000
+++ account_followup/account_followup_customers.xml 2013-03-08 12:58:22 +0000
@@ -39,7 +39,7 @@
39 <field name="model">res.partner</field>39 <field name="model">res.partner</field>
40 <field name="inherit_id" ref="base.view_res_partner_filter"/>40 <field name="inherit_id" ref="base.view_res_partner_filter"/>
41 <field name="arch" type="xml">41 <field name="arch" type="xml">
42 <search string="Search Partner" position="inside">42 <field name="parent_id" postion="after">
43 <group string="Follow-up">43 <group string="Follow-up">
44 <filter string="Partners with Overdue Credits" domain="[('payment_amount_overdue', '>', 0.0)]" name="credits"/>44 <filter string="Partners with Overdue Credits" domain="[('payment_amount_overdue', '>', 0.0)]" name="credits"/>
45 <separator/>45 <separator/>
@@ -48,10 +48,10 @@
48 <filter string="No Responsible" domain="[('payment_responsible_id', '=', False)]"/>48 <filter string="No Responsible" domain="[('payment_responsible_id', '=', False)]"/>
49 <filter string="My Follow-ups" domain="[('payment_responsible_id','=', uid)]" name="my"/>49 <filter string="My Follow-ups" domain="[('payment_responsible_id','=', uid)]" name="my"/>
50 </group>50 </group>
51 <group expand="1" string="Group By...">51 </field>
52 <filter string="Follow-up Responsible" context="{'group_by':'payment_responsible_id'}"/>52 <xpath expr="//filter[@string=&quot;Country&quot;]" position="after">
53 </group>53 <filter string="Follow-up Responsible" context="{'group_by':'payment_responsible_id'}"/>
54 </search>54 </xpath>
55 </field>55 </field>
56 </record>56 </record>
5757