Merge lp:~openerp-dev/openobject-addons/7.0-fix-mail_issues-adh into lp:openobject-addons/7.0

Proposed by Anand Dharampuriya(OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-addons/7.0-fix-mail_issues-adh
Merge into: lp:openobject-addons/7.0
Diff against target: 56 lines (+10/-2)
3 files modified
mail/mail_group.py (+4/-1)
mail/mail_thread.py (+1/-1)
mail/static/src/css/mail.css (+5/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/7.0-fix-mail_issues-adh
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+222933@code.launchpad.net

Description of the change

Hello,

I had fixed some mail issues which are currently present in 7.0/addons.

Regards,
ADH

To post a comment you must log in.

Unmerged revisions

10064. By Anand Dharampuriya(OpenERP)

[FIX] Solve some mail issues which are currently present in 7.0/addons

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'mail/mail_group.py'
--- mail/mail_group.py 2013-08-27 15:07:08 +0000
+++ mail/mail_group.py 2014-06-12 12:07:36 +0000
@@ -24,6 +24,7 @@
24from openerp.osv import osv24from openerp.osv import osv
25from openerp.osv import fields25from openerp.osv import fields
26from openerp import SUPERUSER_ID26from openerp import SUPERUSER_ID
27from openerp.tools.translate import _
2728
2829
29class mail_group(osv.Model):30class mail_group(osv.Model):
@@ -46,7 +47,7 @@
4647
47 _columns = {48 _columns = {
48 'name': fields.char('Name', size=64, required=True, translate=True),49 'name': fields.char('Name', size=64, required=True, translate=True),
49 'description': fields.text('Description'),50 'description': fields.text('Description', translate=True),
50 'menu_id': fields.many2one('ir.ui.menu', string='Related Menu', required=True, ondelete="cascade"),51 'menu_id': fields.many2one('ir.ui.menu', string='Related Menu', required=True, ondelete="cascade"),
51 'public': fields.selection([('public', 'Public'), ('private', 'Private'), ('groups', 'Selected Group Only')], 'Privacy', required=True,52 'public': fields.selection([('public', 'Public'), ('private', 'Private'), ('groups', 'Selected Group Only')], 'Privacy', required=True,
52 help='This group is visible by non members. \53 help='This group is visible by non members. \
@@ -172,6 +173,8 @@
172 mail_alias = self.pool.get('mail.alias')173 mail_alias = self.pool.get('mail.alias')
173 alias_ids = [group.alias_id.id for group in groups if group.alias_id]174 alias_ids = [group.alias_id.id for group in groups if group.alias_id]
174 # Delete mail_group175 # Delete mail_group
176 if self.pool['ir.model.data'].get_object_reference(cr, uid, 'mail', 'group_all_employees')[1] in ids:
177 raise osv.except_osv(_('Warning!'), _('You cannot delete this group because some other modules are dependent on it'))
175 res = super(mail_group, self).unlink(cr, uid, ids, context=context)178 res = super(mail_group, self).unlink(cr, uid, ids, context=context)
176 # Delete alias179 # Delete alias
177 mail_alias.unlink(cr, SUPERUSER_ID, alias_ids, context=context)180 mail_alias.unlink(cr, SUPERUSER_ID, alias_ids, context=context)
178181
=== modified file 'mail/mail_thread.py'
--- mail/mail_thread.py 2014-05-05 09:43:29 +0000
+++ mail/mail_thread.py 2014-06-12 12:07:36 +0000
@@ -944,7 +944,7 @@
944 return result944 return result
945 if partner and partner in obj.message_follower_ids: # recipient already in the followers -> skip945 if partner and partner in obj.message_follower_ids: # recipient already in the followers -> skip
946 return result946 return result
947 if partner and partner in [val[0] for val in result[obj.id]]: # already existing partner ID -> skip947 if partner and partner.id in [val[0] for val in result[obj.id]]: # already existing partner ID -> skip
948 return result948 return result
949 if partner and partner.email: # complete profile: id, name <email>949 if partner and partner.email: # complete profile: id, name <email>
950 result[obj.id].append((partner.id, '%s<%s>' % (partner.name, partner.email), reason))950 result[obj.id].append((partner.id, '%s<%s>' % (partner.name, partner.email), reason))
951951
=== modified file 'mail/static/src/css/mail.css'
--- mail/static/src/css/mail.css 2014-02-14 13:17:05 +0000
+++ mail/static/src/css/mail.css 2014-06-12 12:07:36 +0000
@@ -672,3 +672,8 @@
672.openerp .oe_mail .oe_view_nocontent > p {672.openerp .oe_mail .oe_view_nocontent > p {
673 padding-left: 15px;673 padding-left: 15px;
674}674}
675@media print {
676 .openerp .oe_form div.oe_chatter {
677 display: none !important;
678 }
679}
675\ No newline at end of file680\ No newline at end of file