Code review comment for lp:~openerp-dev/openobject-addons/6.1-opw-576381-bth

Hello,

nice to see you have targeted the root cause. However the fix needs a bit improvement both technically

like you can improve the for loop
map(lambda x: base_calendar.base_calendar_id2real_id(x), ids2)

secondly I don't see the use of this * import from crm_meeting import crm_meeting * statement

and finally in the realids variable you will have the duplicated ids list..for eg I have a meeting ID 7 with 5 recurrency..so I will have virtual ids as something like this ['7-20121013000000', '7-20121012000000', '7-20121011000000', '7-20121015000000', '7-20121014000000'] now when you convert this to real ids you need to also check whether the ids is not already present otherwise you will end up with extra looping in this case(4 extra calls) and the final result will be [7,7,7,7,7]

can you please improve this ?

Thanks,
Naresh